Make signurl work with objects containing tildes. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://issuetracker.google.com/issues/133019153 Per the docs, the tilde character should not be percent-encoded: When defining the path to the resource, you must percent encode the following reserved characters: ?=!#$&'()*+,:;@[]." https://cloud.google.com/storage/docs/access-control/signing-urls-manually Note that Python 3's urllib quote method ignores the tilde, but Python 2's does not: - Py2 docs: "Letters, digits, and the characters '_.-' are never quoted." - Py3 docs: "Letters, digits, and the characters '_.-~' are never quoted."
houglum
added a commit
to houglum/gsutil
that referenced
this pull request
Jun 28, 2019
The tilde behavior was changed between 2 and 3; this also bit us in another issue, see GoogleCloudPlatform#783.
This was referenced Jun 28, 2019
houglum
added a commit
that referenced
this pull request
Jun 28, 2019
The tilde behavior was changed between 2 and 3; this also bit us in another issue, see #783.
houglum
added a commit
that referenced
this pull request
Jun 28, 2019
The tilde behavior was changed between 2 and 3; this also bit us in another issue, see #783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issuetracker.google.com/issues/133019153
Per the docs, the tilde character should not be percent-encoded:
When defining the path to the resource, you must percent encode the
following reserved characters: ?=!#$&'()*+,:;@[]."
https://cloud.google.com/storage/docs/access-control/signing-urls-manually
Note that Python 3's urllib quote method ignores the tilde, but Python
2's does not: